rdblue commented on pull request #2333: URL: https://github.com/apache/iceberg/pull/2333#issuecomment-807263898
@jackye1995, let's go with the no-arg constructor and remove `final`. Configuration is primarily accessed to create `FileIO`, which can then have a `final` reference. So I don't think this is in a critical path and we shouldn't worry about it. Probably not worth making the contract for dynamic loading more complicated and difficult to maintain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
