rdblue commented on a change in pull request #2365:
URL: https://github.com/apache/iceberg/pull/2365#discussion_r601746834
##########
File path:
spark3-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAlterTablePartitionFields.java
##########
@@ -272,4 +272,76 @@ public void testDropPartitionByName() {
Assert.assertEquals("Should have new spec field", expected, table.spec());
}
+
+ @Test
+ public void testReplacePartition() {
+ sql("CREATE TABLE %s (id bigint NOT NULL, category string, ts timestamp,
data string) USING iceberg", tableName);
+ Table table = validationCatalog.loadTable(tableIdent);
+ Assert.assertTrue("Table should start unpartitioned",
table.spec().isUnpartitioned());
+
+ sql("ALTER TABLE %s ADD PARTITION FIELD days(ts)", tableName);
+ table.refresh();
+ PartitionSpec expected = PartitionSpec.builderFor(table.schema())
+ .withSpecId(1)
+ .day("ts")
+ .build();
+ Assert.assertEquals("Should have new spec field", expected, table.spec());
+
+ sql("ALTER TABLE %s REPLACE PARTITION FIELD days(ts) TO hours(ts)",
tableName);
+ table.refresh();
+ expected = PartitionSpec.builderFor(table.schema())
+ .withSpecId(2)
+ .alwaysNull("ts", "ts_day")
+ .hour("ts")
+ .build();
+ Assert.assertEquals("Should changed from daily to hourly partitioned
field", expected, table.spec());
+ }
+
+ @Test
+ public void testReplacePartitionAndRename() {
+ sql("CREATE TABLE %s (id bigint NOT NULL, category string, ts timestamp,
data string) USING iceberg", tableName);
+ Table table = validationCatalog.loadTable(tableIdent);
+ Assert.assertTrue("Table should start unpartitioned",
table.spec().isUnpartitioned());
+
+ sql("ALTER TABLE %s ADD PARTITION FIELD days(ts)", tableName);
+ table.refresh();
+ PartitionSpec expected = PartitionSpec.builderFor(table.schema())
+ .withSpecId(1)
+ .day("ts")
+ .build();
+ Assert.assertEquals("Should have new spec field", expected, table.spec());
+
+ sql("ALTER TABLE %s REPLACE PARTITION FIELD days(ts) TO hours(ts) AS
hour_col", tableName);
+ table.refresh();
+ expected = PartitionSpec.builderFor(table.schema())
+ .withSpecId(2)
+ .alwaysNull("ts", "ts_day")
+ .hour("ts", "hour_col")
+ .build();
+ Assert.assertEquals("Should changed from daily to hourly partitioned
field", expected, table.spec());
+ }
+
+ @Test
+ public void testReplaceNamedPartition() {
+ sql("CREATE TABLE %s (id bigint NOT NULL, category string, ts timestamp,
data string) USING iceberg", tableName);
+ Table table = validationCatalog.loadTable(tableIdent);
+ Assert.assertTrue("Table should start unpartitioned",
table.spec().isUnpartitioned());
+
+ sql("ALTER TABLE %s ADD PARTITION FIELD days(ts) AS day_col", tableName);
+ table.refresh();
+ PartitionSpec expected = PartitionSpec.builderFor(table.schema())
+ .withSpecId(1)
+ .day("ts", "day_col")
+ .build();
+ Assert.assertEquals("Should have new spec field", expected, table.spec());
+
+ sql("ALTER TABLE %s REPLACE PARTITION FIELD day_col TO hours(ts)",
tableName);
+ table.refresh();
+ expected = PartitionSpec.builderFor(table.schema())
+ .withSpecId(2)
+ .alwaysNull("ts", "day_col")
+ .hour("ts")
Review comment:
I think this should retain the original name. But then the problem is
that `day_col` is reused. We'll have to rename the old field in that case, if
that doesn't already happen in the spec evolution code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
