jackye1995 commented on a change in pull request #2365:
URL: https://github.com/apache/iceberg/pull/2365#discussion_r601867050
##########
File path:
spark3-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4
##########
@@ -69,6 +69,7 @@ statement
: CALL multipartIdentifier '(' (callArgument (',' callArgument)*)? ')'
#call
| ALTER TABLE multipartIdentifier ADD PARTITION FIELD transform (AS
name=identifier)? #addPartitionField
| ALTER TABLE multipartIdentifier DROP PARTITION FIELD transform
#dropPartitionField
+ | ALTER TABLE multipartIdentifier REPLACE PARTITION FIELD transform TO
transform (AS name=identifier)? #replacePartitionField
Review comment:
Currently we strictly disallow rename -> delete renamed field -> add
field with the same name in a single commit for use case 1, but I think that
sounds like something we can support in `BaseUpdatePartitionSpec`, I am
thinking about any consequence of it, will update later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
