marton-bod commented on a change in pull request #2228:
URL: https://github.com/apache/iceberg/pull/2228#discussion_r603189241
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
##########
@@ -190,7 +210,8 @@ static void overlayTableProperties(Configuration
configuration, TableDesc tableD
map.put(InputFormatConfig.TABLE_SCHEMA, schemaJson);
if (table instanceof Serializable) {
- map.put(InputFormatConfig.SERIALIZED_TABLE,
SerializationUtil.serializeToBase64(table));
+ map.put(InputFormatConfig.SERIALIZED_TABLE_PREFIX +
tableDesc.getTableName(),
Review comment:
Once we have the table-level catalog config merged, will it be enough to
use the tableName here? E.g. if we write to `db.tbl` from Catalog A and
`db.tbl` from Catalog B in the same query, won't they have the same value for
`tableDesc.getTableName()` and therefore the second one will overwrite the
first one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
