pvary commented on a change in pull request #2228:
URL: https://github.com/apache/iceberg/pull/2228#discussion_r603213605
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java
##########
@@ -129,6 +128,8 @@
scan = scan.filter(filter);
}
+ FileIO io = table.io();
Review comment:
Yeah.
We need to use them in the lambda. Can not use the `table` because it is not
`finallike`. So either I have to do some magic like:
```
Table nonFinalTable = HiveIcebergStorageHandler.table(conf,
conf.get(InputFormatConfig.TABLE_IDENTIFIER));
Table table = nonFinalTable != null ? nonFinalTable :
Catalogs.loadTable(conf);
```
or I have do the same with the `io`, `encryption`.
I call for a vote which is uglier 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
