pvary commented on a change in pull request #2228:
URL: https://github.com/apache/iceberg/pull/2228#discussion_r603224764
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
##########
@@ -108,7 +112,13 @@ public void configureInputJobCredentials(TableDesc
tableDesc, Map<String, String
public void configureJobConf(TableDesc tableDesc, JobConf jobConf) {
if (tableDesc != null && tableDesc.getProperties() != null &&
tableDesc.getProperties().get(WRITE_KEY) != null) {
+ Preconditions.checkArgument(!tableDesc.getTableName().contains(".."),
Review comment:
Good point. Fixed
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
##########
@@ -142,12 +152,22 @@ public DecomposedPredicate decomposePredicate(JobConf
jobConf, Deserializer dese
}
/**
- * Returns the Table serialized to the configuration.
+ * Returns the Table serialized to the configuration based on the table name.
* @param config The configuration used to get the data from
+ * @param name The name of the table we need as returned by
TableDesc.getTableName()
* @return The Table
*/
- public static Table table(Configuration config) {
- return
SerializationUtil.deserializeFromBase64(config.get(InputFormatConfig.SERIALIZED_TABLE));
+ public static Table table(Configuration config, String name) {
+ return
SerializationUtil.deserializeFromBase64(config.get(InputFormatConfig.SERIALIZED_TABLE_PREFIX
+ name));
+ }
+
+ /**
+ * Returns the names of tha output tables stored in the configuration.
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
