aokolnychyi commented on a change in pull request #2362:
URL: https://github.com/apache/iceberg/pull/2362#discussion_r604421697
##########
File path: api/src/main/java/org/apache/iceberg/types/Type.java
##########
@@ -111,6 +112,23 @@ public PrimitiveType asPrimitiveType() {
Object writeReplace() throws ObjectStreamException {
return new PrimitiveHolder(toString());
}
+
+ @Override
+ public int hashCode() {
+ return Objects.hashCode(typeId());
+ }
+
+ @Override
+ public boolean equals(Object other) {
Review comment:
I am also concerned about this.
I think we have the following alternative options:
- Pass spec and schema as json strings and deserialize as needed.
- Register a custom Kryo serializer for needed classes.
I think we would want to avoid the second option if we can. Passing schema
and spec as JSON could work. Thoughts, @rdblue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
