rdblue commented on a change in pull request #2362:
URL: https://github.com/apache/iceberg/pull/2362#discussion_r604426221
##########
File path: api/src/main/java/org/apache/iceberg/types/Type.java
##########
@@ -111,6 +112,23 @@ public PrimitiveType asPrimitiveType() {
Object writeReplace() throws ObjectStreamException {
return new PrimitiveHolder(toString());
}
+
+ @Override
+ public int hashCode() {
+ return Objects.hashCode(typeId());
+ }
+
+ @Override
+ public boolean equals(Object other) {
Review comment:
Yeah, that sounds like a good option. I think we should probably do
both. There isn't too much overhead to `equals` so we should start ensuring we
correctly use it all the time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
