jackye1995 commented on a change in pull request #2354:
URL: https://github.com/apache/iceberg/pull/2354#discussion_r605813283
##########
File path: api/src/main/java/org/apache/iceberg/catalog/Catalog.java
##########
@@ -22,6 +22,7 @@
import java.util.List;
import java.util.Map;
import org.apache.iceberg.PartitionSpec;
+import org.apache.iceberg.RowKey;
Review comment:
That's a good point, I thought about that, and there were 2 reasons that
let me decide to not add it:
1. currently both Spark and Hive SQL specification does not allow a primary
key clause. I would expect the user to run something like `ALTER TABLE ... ADD
ROW KEY` (actual syntax TBD) to add this row key in Spark.
2. it's now becoming hard to iterate through all the combinations of
parameters in `createTable`, we do not have the methods with SortOrder in
parameter yet, although it can be mapped to `SORTED BY` clause. I would prefer
us to switch to use the table builder if possible instead of adding all those
overloading methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
