jackye1995 commented on a change in pull request #2354:
URL: https://github.com/apache/iceberg/pull/2354#discussion_r605993041
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -482,6 +506,7 @@ public TableMetadata updateSchema(Schema newSchema, int
newLastColumnId) {
// rebuild all of the partition specs and sort orders for the new current
schema
List<PartitionSpec> updatedSpecs = Lists.transform(specs, spec ->
updateSpecSchema(newSchema, spec));
List<SortOrder> updatedSortOrders = Lists.transform(sortOrders, order ->
updateSortOrderSchema(newSchema, order));
+ RowKey updatedRowKey = updateRowKeySchema(newSchema, rowKey);
Review comment:
That's a good point, I was thinking about having another PR for blocking
column drop for column in row key after this one, do you think it's better to
have it here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
