jackye1995 commented on a change in pull request #2354:
URL: https://github.com/apache/iceberg/pull/2354#discussion_r606003885
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -482,6 +506,7 @@ public TableMetadata updateSchema(Schema newSchema, int
newLastColumnId) {
// rebuild all of the partition specs and sort orders for the new current
schema
List<PartitionSpec> updatedSpecs = Lists.transform(specs, spec ->
updateSpecSchema(newSchema, spec));
List<SortOrder> updatedSortOrders = Lists.transform(sortOrders, order ->
updateSortOrderSchema(newSchema, order));
+ RowKey updatedRowKey = updateRowKeySchema(newSchema, rowKey);
Review comment:
I was thinking about the following: 1 PR for the update related changes
including update row key API, implementation, and this fix in schema update;
1PR for work in Spark for SQL extension; 1PR in Flink for primary key clause
(if no one did it yet)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
