aokolnychyi commented on a change in pull request #2362:
URL: https://github.com/apache/iceberg/pull/2362#discussion_r608852838
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/source/RowDataRewriter.java
##########
@@ -49,34 +46,21 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import static org.apache.iceberg.TableProperties.DEFAULT_NAME_MAPPING;
-
public class RowDataRewriter implements Serializable {
private static final Logger LOG =
LoggerFactory.getLogger(RowDataRewriter.class);
- private final Schema schema;
+ private final Broadcast<Table> tableBroadcast;
private final PartitionSpec spec;
- private final Map<String, String> properties;
private final FileFormat format;
- private final Broadcast<FileIO> io;
- private final Broadcast<EncryptionManager> encryptionManager;
- private final LocationProvider locations;
- private final String nameMapping;
private final boolean caseSensitive;
- public RowDataRewriter(Table table, PartitionSpec spec, boolean
caseSensitive,
- Broadcast<FileIO> io, Broadcast<EncryptionManager>
encryptionManager) {
- this.schema = table.schema();
+ public RowDataRewriter(Broadcast<Table> tableBroadcast, PartitionSpec spec,
boolean caseSensitive) {
+ this.tableBroadcast = tableBroadcast;
this.spec = spec;
- this.locations = table.locationProvider();
- this.properties = table.properties();
- this.io = io;
- this.encryptionManager = encryptionManager;
-
this.caseSensitive = caseSensitive;
- this.nameMapping = table.properties().get(DEFAULT_NAME_MAPPING);
+ Table table = tableBroadcast.getValue();
Review comment:
You are right, good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
