aokolnychyi commented on a change in pull request #2362:
URL: https://github.com/apache/iceberg/pull/2362#discussion_r608860743
##########
File path: spark2/src/main/java/org/apache/iceberg/spark/source/Writer.java
##########
@@ -123,6 +123,13 @@
this.partitionedFanoutEnabled =
options.getBoolean(SparkWriteOptions.FANOUT_ENABLED,
tablePartitionedFanoutEnabled);
}
+ protected JavaSparkContext lazySparkContext() {
Review comment:
The Java one is a bit more friendly for Java. For example, here is how
`broadcast` is defined:
```
def broadcast[T: ClassTag](value: T): Broadcast[T] // Scala
def broadcast[T](value: T): Broadcast[T] = sc.broadcast(value)(fakeClassTag)
// Java
```
We would need to pass a class tag ourselves if we used the Scala one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
