flyrain commented on pull request #2438: URL: https://github.com/apache/iceberg/pull/2438#issuecomment-816121533
> This looks good to me. > > Should we add the same check in Flink which also supports altering table properties via alter table statements? Or, would it be possible to make the change somewhere in core or api etc such that we don't need engine specific controls for this? > > This could be a follow up task of course. I believe Flink needs the same thing, not sure though. Ideally, reserved table properties should be platform agnostic, so that we don't have to make duplicate changes. I agree that could be another PR. Also needs people's thoughts. cc @aokolnychyi , @RussellSpitzer , @rdblue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
