RussellSpitzer commented on a change in pull request #2438:
URL: https://github.com/apache/iceberg/pull/2438#discussion_r611909007
##########
File path: spark3/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
##########
@@ -199,6 +199,9 @@ public SparkTable alterTable(Identifier ident,
TableChange... changes) throws No
setSnapshotId = set;
} else if ("cherry-pick-snapshot-id".equalsIgnoreCase(set.property()))
{
pickSnapshotId = set;
+ } else if ("sort-order".equalsIgnoreCase(set.property())) {
+ throw new UnsupportedOperationException("'sort-order' is a reserved
table property. Please use the command " +
+ "'ALTER TABLE ... WRITE ORDERED BY' to specify it.");
Review comment:
One nit here I forgot about this before but we usually structure error
messages as
"Cannot X because Y. Then the recommendation goes here"
I would also recommend not using "it" in the message since it the pronoun is
a bit ambiguous. "to specify write sort-order" may be clearer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
