RussellSpitzer commented on a change in pull request #2415:
URL: https://github.com/apache/iceberg/pull/2415#discussion_r611899010
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/actions/BaseSparkAction.java
##########
@@ -163,7 +163,7 @@ protected Table newStaticTable(TableMetadata metadata,
FileIO io) {
}
protected Dataset<Row> buildManifestFileDF(Table table) {
- return loadMetadataTable(table, ALL_MANIFESTS).selectExpr("path as
file_path");
+ return loadMetadataTable(table, ALL_MANIFESTS).selectExpr("path as
file_path").distinct();
Review comment:
Basically I think distinct should be called by the caller after making
the union if that is required, rather than always calling distinct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
