jackye1995 commented on a change in pull request #2415: URL: https://github.com/apache/iceberg/pull/2415#discussion_r620828060
########## File path: api/src/main/java/org/apache/iceberg/actions/RemoveFiles.java ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.actions; + +import java.util.concurrent.ExecutorService; +import java.util.function.Consumer; + +/** + * An action that deletes data, manifest, manifest lists in a table. + * <p> + * Implementations may use a query engine to distribute parts of work. + */ +public interface RemoveFiles extends Action<RemoveFiles, RemoveFiles.Result> { + + /** + * Passes an alternative delete implementation that will be used for manifests and data files. + * <p> Review comment: nit: I don't think we need the `<p>` at the end of doc. ########## File path: api/src/main/java/org/apache/iceberg/actions/RemoveFiles.java ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.actions; + +import java.util.concurrent.ExecutorService; +import java.util.function.Consumer; + +/** + * An action that deletes data, manifest, manifest lists in a table. + * <p> + * Implementations may use a query engine to distribute parts of work. + */ +public interface RemoveFiles extends Action<RemoveFiles, RemoveFiles.Result> { + + /** + * Passes an alternative delete implementation that will be used for manifests and data files. + * <p> + * + * @param deleteFunc a function that will be called to delete manifests and data files Review comment: nit: could you add more description for what the string in the consumer means for the function? It might be not clear for the readers. ########## File path: api/src/main/java/org/apache/iceberg/actions/RemoveFiles.java ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.actions; + +import java.util.concurrent.ExecutorService; +import java.util.function.Consumer; + +/** + * An action that deletes data, manifest, manifest lists in a table. + * <p> + * Implementations may use a query engine to distribute parts of work. + */ +public interface RemoveFiles extends Action<RemoveFiles, RemoveFiles.Result> { + + /** + * Passes an alternative delete implementation that will be used for manifests and data files. + * <p> + * + * @param deleteFunc a function that will be called to delete manifests and data files + * @return this for method chaining + */ + RemoveFiles deleteWith(Consumer<String> deleteFunc); + + /** + * Passes an alternative executor service that will be used for manifests and data files deletion. + * <p> + * If this method is not called, manifests and data files will still be deleted in + * the current thread. + * <p> + * + * @param executorService the service to use + * @return this for method chaining + */ + RemoveFiles executeDeleteWith(ExecutorService executorService); + + /** + * The action result that contains a summary of the execution. + */ + interface Result { + /** + * Returns the number of deleted data files. + */ + long deletedDataFilesCount(); + + /** + * Returns the number of deleted manifests. + */ + long deletedManifestsCount(); + + /** + * Returns the number of deleted manifest lists. + */ + long deletedManifestListsCount(); + + /** + * Returns the number of files deleted other than data, manifest and manifest list. Review comment: how are we treating delete files? We do we not have another `long deletedDeleteFilesCount()`? I know we don't have utils like `buildValidDeleteFileDF` yet, but I think it would be good to start add those in, and this action seems to be a good one to add that, maybe collaborate a bit on the timing with #2518. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
