RussellSpitzer commented on a change in pull request #2452:
URL: https://github.com/apache/iceberg/pull/2452#discussion_r614870100
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/actions/BaseSparkAction.java
##########
@@ -159,7 +159,7 @@ protected Table newStaticTable(TableMetadata metadata,
FileIO io) {
.repartition(spark.sessionState().conf().numShufflePartitions()) //
avoid adaptive execution combining tasks
.as(Encoders.bean(ManifestFileBean.class));
- return allManifests.flatMap(new ReadManifest(ioBroadcast),
Encoders.STRING()).toDF("file_path");
+ return allManifests.flatMap(new ReadManifest(ioBroadcast),
Encoders.STRING()).toDF("file_path").distinct();
Review comment:
I left my thoughts on the other or but I think deduping shouldn't happen
here because we end up with multiple shuffle stages in expire snapshots instead
of just the one. An api that wants to call distinct can always do so on the
return value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
