karuppayya commented on a change in pull request #2452:
URL: https://github.com/apache/iceberg/pull/2452#discussion_r616936525



##########
File path: 
spark/src/main/java/org/apache/iceberg/spark/actions/BaseSparkAction.java
##########
@@ -173,7 +173,7 @@ protected Table newStaticTable(TableMetadata metadata, 
FileIO io) {
 
   protected Dataset<Row> buildOtherMetadataFileDF(TableOperations ops) {
     List<String> otherMetadataFiles = getOtherMetadataFilePaths(ops);
-    return spark.createDataset(otherMetadataFiles, 
Encoders.STRING()).toDF("file_path");
+    return spark.createDataset(otherMetadataFiles, 
Encoders.STRING()).toDF("file_path").distinct();

Review comment:
       @aokolnychyi This current code does not do a recursive listing of all 
the version metadata json files. 
   I have made changes to https://github.com/apache/iceberg/pull/2415 to do a 
recursive listing and also deduped the files as part of the change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to