jackye1995 commented on a change in pull request #2465:
URL: https://github.com/apache/iceberg/pull/2465#discussion_r617122093
##########
File path: core/src/main/java/org/apache/iceberg/SchemaUpdate.java
##########
@@ -317,6 +320,31 @@ public UpdateSchema unionByNameWith(Schema newSchema) {
return this;
}
+ @Override
+ public UpdateSchema setIdentifierFields(Set<String> names) {
+ identifierFields = Sets.newHashSet();
+ names.forEach(this::addIdentifierField);
+ return this;
+ }
+
+ private void addIdentifierField(String name) {
+ Types.NestedField field = schema.findField(name);
+ if (field == null) {
+ field = adds.get(TABLE_ROOT_ID).stream()
+ .filter(f -> f.name().equals(name))
+ .findAny().orElse(null);
+ } else {
+ Preconditions.checkArgument(idToParent.get(field.fieldId()) == null,
+ "Cannot add column %s as an identifier: must not be nested in a map
or list", name);
Review comment:
I see, in this implementation I did not allow a field in a struct,
that's why I implemented it this way. But it does make sense now I think about
it, I will update the code for that use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
