rdblue commented on a change in pull request #2465:
URL: https://github.com/apache/iceberg/pull/2465#discussion_r617123843
##########
File path: core/src/main/java/org/apache/iceberg/SchemaUpdate.java
##########
@@ -317,6 +320,31 @@ public UpdateSchema unionByNameWith(Schema newSchema) {
return this;
}
+ @Override
+ public UpdateSchema setIdentifierFields(Set<String> names) {
Review comment:
I think we may want to also keep `addIdentifierField`. There's still a
use case around adding a field at a time. Plus, given that I think we want to
be able to specify the parent (see my comment below), this form of the method
is a bit awkward because we can't pass pairs of strings, `(parent, name)`.
What about changing this to `resetIdentifierFields`, `addIdentifierField`,
and `removeIdentifierField`? I think those get the same job done because `set`
is `reset` plus `add` calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
