openinx commented on a change in pull request #2499:
URL: https://github.com/apache/iceberg/pull/2499#discussion_r619947921
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/source/SparkAppenderFactory.java
##########
@@ -85,6 +72,52 @@
this.posDeleteRowSchema = posDeleteRowSchema;
}
+ public static SparkAppenderFactoryBuilder builderFor(Table table, Schema
writeSchema, StructType dsSchema) {
+ return new SparkAppenderFactoryBuilder(table, writeSchema, dsSchema);
+ }
+
+ public static class SparkAppenderFactoryBuilder {
Review comment:
Since the class `SparkAppenderFactory` was not marked as `public`, so I
think the newly introduced `SparkAppenderFactoryBuilder` also don't have to be
`public` ?
btw, I think we could just use the name `Builder` because it's in the
class `SparkAppenderFactory`, the prefix `SparkAppenderFactory` seems to be
redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
