openinx commented on a change in pull request #2499:
URL: https://github.com/apache/iceberg/pull/2499#discussion_r620808913
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/source/SparkAppenderFactory.java
##########
@@ -85,6 +72,65 @@
this.posDeleteRowSchema = posDeleteRowSchema;
}
+ public static Builder builderFor(Table table, Schema writeSchema, StructType
dsSchema) {
Review comment:
Nit: As iceberg is a library which will be embedded in user's project,
so we usually strictly control methods/classes marked as `public`. In this
case, we don't have to mark this as `public`. Similar comment in the
following `Builder`'s methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
