yyanyy commented on a change in pull request #2538:
URL: https://github.com/apache/iceberg/pull/2538#discussion_r623514621
##########
File path: data/src/main/java/org/apache/iceberg/data/DeleteFilter.java
##########
@@ -253,8 +255,8 @@ private static Schema fileProjection(Schema tableSchema,
Schema requestedSchema,
// TODO: support adding nested columns. this will currently fail when
finding nested columns to add
List<Types.NestedField> columns =
Lists.newArrayList(requestedSchema.columns());
for (int fieldId : missingIds) {
Review comment:
should we add this new metadata column to `requiredIds` above?
##########
File path: flink/src/test/java/org/apache/iceberg/flink/SimpleDataUtil.java
##########
@@ -191,9 +190,19 @@ public static void assertTableRows(Table table,
List<RowData> expected) throws I
public static void assertTableRecords(Table table, List<Record> expected)
throws IOException {
table.refresh();
+
Review comment:
Why do we need this change? is it because two sets don't match after we
add the additional metadata column? but wouldn't `_pos` and `_file` also have
this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
