chenjunjiedada commented on a change in pull request #2538:
URL: https://github.com/apache/iceberg/pull/2538#discussion_r623548330
##########
File path: data/src/main/java/org/apache/iceberg/data/DeleteFilter.java
##########
@@ -253,8 +255,8 @@ private static Schema fileProjection(Schema tableSchema,
Schema requestedSchema,
// TODO: support adding nested columns. this will currently fail when
finding nested columns to add
List<Types.NestedField> columns =
Lists.newArrayList(requestedSchema.columns());
for (int fieldId : missingIds) {
Review comment:
I think the logic here is if the `requestedSchema` doesn't contain the
metadata column, we add them to the end. the `requiredIds` already has metadata
columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
