jackye1995 opened a new pull request #2556:
URL: https://github.com/apache/iceberg/pull/2556


   fixes #2528 
   
   Allow callers of the schema constructor to take in identifier information 
and refresh the identifier field IDs if necessary.
   
   This mostly applies to schema update related code paths. The following 2 
cases will continue to use the existing constructor without identifier:
   
   1. callers that are coverting from a file format schema or an engine schema 
except Flink, because they do not have a primary key-like concept.
       1. I assume @openinx will do all necessary changes in Flink through 
#2410. 
       2. I will do another PR for Spark with SQL extension added.
   2. callers that are converting schema for query transformation purpose such 
as `select`, `join`, file projection, etc., because identifier is not 
well-defined for those transformed schemas.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to