openinx commented on a change in pull request #2556:
URL: https://github.com/apache/iceberg/pull/2556#discussion_r627362642
##########
File path: api/src/main/java/org/apache/iceberg/types/TypeUtil.java
##########
@@ -181,10 +183,24 @@ public static Schema assignFreshIds(int schemaId, Schema
schema, NextID nextId)
* @return a structurally identical schema with new ids assigned by the
nextId function
*/
public static Schema assignFreshIds(Schema schema, Schema baseSchema, NextID
nextId) {
- return new Schema(TypeUtil
- .visit(schema.asStruct(), new AssignFreshIds(schema, baseSchema,
nextId))
- .asNestedType()
- .fields());
+ Types.StructType freshSchemaStruct = TypeUtil
Review comment:
Another thing (unrelated to this PR but I think it's important): when
we reconstruct the `Schema` in `assignFreshIds`, looks like we've ignored the
`Map<String, Integer> aliases`, that not seems the correct behavior, right ? I
mean we should use the existing `aliases` from the old schema to construct the
refreshed new schema .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
