jackye1995 commented on a change in pull request #2560:
URL: https://github.com/apache/iceberg/pull/2560#discussion_r629804140
##########
File path:
spark3-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4
##########
@@ -71,6 +71,8 @@ statement
| ALTER TABLE multipartIdentifier DROP PARTITION FIELD transform
#dropPartitionField
| ALTER TABLE multipartIdentifier REPLACE PARTITION FIELD transform WITH
transform (AS name=identifier)? #replacePartitionField
| ALTER TABLE multipartIdentifier WRITE writeSpec
#setWriteDistributionAndOrdering
+ | ALTER TABLE multipartIdentifier REPLACE ROW_IDENTIFIER FIELDS '('
fields+=identifier (',' fields+=identifier)* ')' #replaceIdentifierFields
Review comment:
yeah `SET` makes sense to me. Was trying to reuse `REPLACE` keyword, but
it does feel awkward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
