rdblue commented on a change in pull request #2560:
URL: https://github.com/apache/iceberg/pull/2560#discussion_r637272965
##########
File path:
spark3-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4
##########
@@ -71,6 +71,8 @@ statement
| ALTER TABLE multipartIdentifier DROP PARTITION FIELD transform
#dropPartitionField
| ALTER TABLE multipartIdentifier REPLACE PARTITION FIELD transform WITH
transform (AS name=identifier)? #replacePartitionField
| ALTER TABLE multipartIdentifier WRITE writeSpec
#setWriteDistributionAndOrdering
+ | ALTER TABLE multipartIdentifier SET ROW_IDENTIFIER FIELDS '('
fields+=identifier (',' fields+=identifier)* ')' #setIdentifierFields
+ | ALTER TABLE multipartIdentifier UNSET ROW_IDENTIFIER FIELDS '('
fields+=identifier (',' fields+=identifier)* ')' #unsetIdentifierFields
Review comment:
What about `DROP` instead of `UNSET` since this is dropping identifier
fields from the set?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
