pvary commented on a change in pull request #2565:
URL: https://github.com/apache/iceberg/pull/2565#discussion_r632390890
##########
File path: mr/src/main/java/org/apache/iceberg/mr/InputFormatConfig.java
##########
@@ -203,6 +202,44 @@ public static Schema readSchema(Configuration conf) {
return readColumns != null && readColumns.length > 0 ? readColumns : null;
}
+ /**
+ * Get Hadoop config key of catalog type based on catalog name and {@link
#CATALOG_TYPE_TEMPLATE}
+ * @param catalogName catalog name
+ * @return Hadoop config key of catalog type for the catalog name
+ */
+ public static String catalogTypeConfigKey(String catalogName) {
+ return String.format(InputFormatConfig.CATALOG_TYPE_TEMPLATE, catalogName);
+ }
+
+ /**
+ * Get Hadoop config key of catalog warehouse location based on catalog name
+ * @param catalogName catalog name
+ * @return Hadoop config key of catalog warehouse location for the catalog
name
+ */
+ public static String catalogWarehouseConfigKey(String catalogName) {
Review comment:
The `warehouse` should be an internal thing for the HadoopCatalog. I
think no other Catalog should use that. Do I miss something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
