jackye1995 commented on a change in pull request #2565:
URL: https://github.com/apache/iceberg/pull/2565#discussion_r633155294
##########
File path: mr/src/main/java/org/apache/iceberg/mr/Catalogs.java
##########
@@ -267,8 +265,8 @@ public static boolean hiveCatalog(Configuration conf,
Properties props) {
*/
private static String getCatalogType(Configuration conf, String catalogName)
{
if (catalogName != null) {
- String catalogType =
conf.get(String.format(InputFormatConfig.CATALOG_TYPE_TEMPLATE, catalogName));
- if (catalogName.equals(ICEBERG_HADOOP_TABLE_NAME) || catalogType ==
null) {
+ String catalogType =
conf.get(InputFormatConfig.catalogTypeConfigKey(catalogName));
+ if (catalogName.equals(ICEBERG_HADOOP_TABLE_NAME)) {
Review comment:
I moved the doc of this method to `Catalogs` class level, because
private method docs are not generated in html.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
