pvary commented on a change in pull request #2565:
URL: https://github.com/apache/iceberg/pull/2565#discussion_r633435261
##########
File path: mr/src/main/java/org/apache/iceberg/mr/InputFormatConfig.java
##########
@@ -203,6 +202,44 @@ public static Schema readSchema(Configuration conf) {
return readColumns != null && readColumns.length > 0 ? readColumns : null;
}
+ /**
+ * Get Hadoop config key of catalog type based on catalog name and {@link
#CATALOG_TYPE_TEMPLATE}
+ * @param catalogName catalog name
+ * @return Hadoop config key of catalog type for the catalog name
+ */
+ public static String catalogTypeConfigKey(String catalogName) {
+ return String.format(InputFormatConfig.CATALOG_TYPE_TEMPLATE, catalogName);
+ }
+
+ /**
+ * Get Hadoop config key of catalog warehouse location based on catalog name
+ * @param catalogName catalog name
+ * @return Hadoop config key of catalog warehouse location for the catalog
name
+ */
+ public static String catalogWarehouseConfigKey(String catalogName) {
Review comment:
I might missing something, but we use this `catalogWarehouseConfigKey`
only in tests. The reason here is that in the tests we would like to set / get
the warehouse for the HadoopCatalog and the CustomCatalog (which is again only
a test class). In production code we do not need this key, so I think we should
move it from the live code to a test class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
