szehon-ho commented on pull request #2608: URL: https://github.com/apache/iceberg/pull/2608#issuecomment-844347011
@flyrain thanks for the review, so to understand, you would prefer a result of Map of individual manifest-entry changes instead of a summary of manifest-files changed? I was thinking that but was fearing it would be too big of a result. But if we want this way (and extend this to a diff tool), we could change to return a List of something like: RepairedManifestEntry(ManifestFile parentFile, DataFile entry, List<String> repairedFields) Is that in line with your thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
