rdblue commented on a change in pull request #2608:
URL: https://github.com/apache/iceberg/pull/2608#discussion_r635650393
##########
File path: api/src/main/java/org/apache/iceberg/actions/RewriteManifests.java
##########
@@ -56,6 +57,26 @@
*/
RewriteManifests stagingLocation(String stagingLocation);
+
+ /**
+ * Allows reading of data files to repair them.
+ * @param mode repair mode
+ * @return this for method chaining
+ */
+ RewriteManifests repair(RepairMode mode);
Review comment:
I generally prefer to use configuration methods rather than enums in
public APIs. That would also allow us to avoid the NONE option and have the
actual repair be a bit more specific, like `repairFileLengths()`. What do you
guys think, @szehon-ho, @RussellSpitzer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
