rdblue commented on a change in pull request #2538:
URL: https://github.com/apache/iceberg/pull/2538#discussion_r637264005



##########
File path: flink/src/test/java/org/apache/iceberg/flink/SimpleDataUtil.java
##########
@@ -191,9 +190,19 @@ public static void assertTableRows(Table table, 
List<RowData> expected) throws I
 
   public static void assertTableRecords(Table table, List<Record> expected) 
throws IOException {
     table.refresh();
+

Review comment:
       I also find this suspicious. Is the extra column in the _expected_ 
records or the table? I don't think that this PR should change the data 
produced by `IcebergGenerics.read(table).build()`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to