aokolnychyi commented on a change in pull request #2415:
URL: https://github.com/apache/iceberg/pull/2415#discussion_r646019056
##########
File path: api/src/main/java/org/apache/iceberg/actions/ActionsProvider.java
##########
@@ -67,4 +67,11 @@ default RewriteDataFiles rewriteDataFiles(Table table) {
default ExpireSnapshots expireSnapshots(Table table) {
throw new UnsupportedOperationException(this.getClass().getName() + " does
not implement expireSnapshots");
}
+
+ /**
+ * Instantiates an action to remove all the files referenced by given
metadata location.
+ */
+ default RemoveReachableFiles removeFiles(String metadataLocation) {
+ throw new UnsupportedOperationException(this.getClass().getName() + " does
not implement removeFiles");
Review comment:
Comment should refer to `removeReachableFiles` as well.
##########
File path: api/src/main/java/org/apache/iceberg/actions/ActionsProvider.java
##########
@@ -67,4 +67,11 @@ default RewriteDataFiles rewriteDataFiles(Table table) {
default ExpireSnapshots expireSnapshots(Table table) {
throw new UnsupportedOperationException(this.getClass().getName() + " does
not implement expireSnapshots");
}
+
+ /**
+ * Instantiates an action to remove all the files referenced by given
metadata location.
+ */
+ default RemoveReachableFiles removeFiles(String metadataLocation) {
Review comment:
I think the name of the method should match the name of the action:
`removeReachableFiles`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
