aokolnychyi commented on a change in pull request #2415: URL: https://github.com/apache/iceberg/pull/2415#discussion_r647847127
########## File path: spark/src/main/java/org/apache/iceberg/spark/actions/BaseRemoveReachableFilesSparkAction.java ########## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.spark.actions; + +import java.util.Iterator; +import java.util.List; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.atomic.AtomicLong; +import java.util.function.Consumer; +import org.apache.iceberg.ReachableFileUtil; +import org.apache.iceberg.Table; +import org.apache.iceberg.TableMetadata; +import org.apache.iceberg.TableMetadataParser; +import org.apache.iceberg.actions.BaseRemoveFilesActionResult; +import org.apache.iceberg.actions.RemoveReachableFiles; +import org.apache.iceberg.exceptions.NotFoundException; +import org.apache.iceberg.hadoop.HadoopFileIO; +import org.apache.iceberg.io.FileIO; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.spark.JobGroupInfo; +import org.apache.iceberg.util.PropertyUtil; +import org.apache.iceberg.util.Tasks; +import org.apache.spark.sql.Dataset; +import org.apache.spark.sql.Encoders; +import org.apache.spark.sql.Row; +import org.apache.spark.sql.SparkSession; +import org.apache.spark.sql.functions; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * An implementation of {@link RemoveReachableFiles} that uses metadata tables in Spark + * to determine which files should be deleted. + */ +@SuppressWarnings("UnnecessaryAnonymousClass") +public class BaseRemoveReachableFilesSparkAction + extends BaseSparkAction<RemoveReachableFiles, RemoveReachableFiles.Result> implements RemoveReachableFiles { + private static final Logger LOG = LoggerFactory.getLogger(BaseRemoveReachableFilesSparkAction.class); + + private static final String DATA_FILE = "Data File"; + private static final String MANIFEST = "Manifest"; + private static final String MANIFEST_LIST = "Manifest List"; + private static final String OTHERS = "Others"; + + private static final String STREAM_RESULTS = "stream-results"; + + // Creates an executor service that runs each task in the thread that invokes execute/submit. + private static final ExecutorService DEFAULT_DELETE_EXECUTOR_SERVICE = null; + + private final String metadataLocation; + private final Consumer<String> defaultDelete = new Consumer<String>() { + @Override + public void accept(String file) { + io.deleteFile(file); + } + }; + + private Consumer<String> removeFunc = defaultDelete; + private ExecutorService removeExecutorService = DEFAULT_DELETE_EXECUTOR_SERVICE; + private FileIO io = new HadoopFileIO(); Review comment: I think we cannot use this constructor for `HadoopFileIO`. This will result in a NPE as it is only meant for dynamic instantiation. It should use the underlying Hadoop conf from the session. ``` new HadoopFileIO(spark().sessionState().newHadoopConf()) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
