nastra commented on a change in pull request #2664:
URL: https://github.com/apache/iceberg/pull/2664#discussion_r649270881
##########
File path: nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java
##########
@@ -137,7 +138,11 @@ protected TableOperations newTableOps(TableIdentifier
tableIdentifier) {
if (pti.reference() != null) {
newReference = loadReference(pti.reference());
}
- return new NessieTableOperations(NessieUtil.toKey(pti.tableIdentifier()),
newReference, client, fileIO);
+ NessieTableOperations tableOperations =
+ new NessieTableOperations(NessieUtil.toKey(pti.tableIdentifier()),
newReference, client, fileIO);
+ // TODO: is there a better way to pass the catalog options to the
TableOperations than this?
Review comment:
for some reason I assumed that the signature of the constructor was
defined and shouldn't be changed. Definitely better to pass this via the
constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
