nastra commented on a change in pull request #2664:
URL: https://github.com/apache/iceberg/pull/2664#discussion_r649390999
##########
File path: nessie/src/main/java/org/apache/iceberg/nessie/NessieUtil.java
##########
@@ -82,10 +92,26 @@ static ContentsKey toKey(TableIdentifier tableIdentifier) {
return key;
}
+ static CommitMeta buildCommitMetadata(String commitMsg, Map<String, String>
catalogOptions) {
+ Preconditions.checkArgument(null != catalogOptions, "catalogOptions must
not be null");
+ ImmutableCommitMeta.Builder cm = CommitMeta.builder().message(commitMsg)
+ .author(NessieUtil.getCommitAuthor(catalogOptions));
+ cm.putProperties(APPLICATION_TYPE, "iceberg");
Review comment:
also currently I think it's fine if the property name is the same as on
the Iceberg side, or do we need to have a clear distinction, wdyt @rymurr ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
