ismailsimsek commented on a change in pull request #1870: URL: https://github.com/apache/iceberg/pull/1870#discussion_r654811272
########## File path: core/src/main/java/org/apache/iceberg/jdbc/JdbcTableOperations.java ########## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.jdbc; + +import java.sql.DataTruncation; +import java.sql.PreparedStatement; +import java.sql.ResultSet; +import java.sql.SQLException; +import java.sql.SQLIntegrityConstraintViolationException; +import java.sql.SQLNonTransientConnectionException; +import java.sql.SQLTimeoutException; +import java.sql.SQLTransientConnectionException; +import java.sql.SQLWarning; +import java.util.Map; +import java.util.Objects; +import org.apache.iceberg.BaseMetastoreTableOperations; +import org.apache.iceberg.TableMetadata; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.exceptions.AlreadyExistsException; +import org.apache.iceberg.exceptions.CommitFailedException; +import org.apache.iceberg.exceptions.NoSuchTableException; +import org.apache.iceberg.io.FileIO; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +class JdbcTableOperations extends BaseMetastoreTableOperations { + + private static final Logger LOG = LoggerFactory.getLogger(JdbcTableOperations.class); + private final String catalogName; + private final TableIdentifier tableIdentifier; + private final FileIO fileIO; + private final JdbcClientPool connections; + + protected JdbcTableOperations(JdbcClientPool dbConnPool, FileIO fileIO, String catalogName, + TableIdentifier tableIdentifier) { + this.catalogName = catalogName; + this.tableIdentifier = tableIdentifier; + this.fileIO = fileIO; + this.connections = dbConnPool; + } + + @Override + public void doRefresh() { + Map<String, String> table; + + try { + table = getTable(); + } catch (InterruptedException e) { + Thread.currentThread().interrupt(); + throw new UncheckedInterruptedException(e, "Interrupted during refresh"); + } catch (SQLException e) { + // SQL exception happened when getting table from catalog + throw new UncheckedSQLException(e, "Failed to get table %s from catalog %s", tableIdentifier, catalogName); + } + + // Table not exists AND currentMetadataLocation is not NULL! + if (table.isEmpty() && currentMetadataLocation() != null) { + throw new NoSuchTableException("Failed to get table %s from catalog %s" + + " maybe another process deleted it", tableIdentifier, catalogName); + } + + // Table not exists in the catalog! metadataLocation is null here! + if (table.isEmpty()) { + refreshFromMetadataLocation(null); + return; + } + + // Table exists but metadataLocation is null + if (table.getOrDefault(JdbcUtil.METADATA_LOCATION, null) == null) { + throw new RuntimeException(String.format("Failed to get metadata location of the table %s from catalog %s", + tableIdentifier, catalogName)); + } + + refreshFromMetadataLocation(table.get(JdbcUtil.METADATA_LOCATION)); + } + + @Override + public void doCommit(TableMetadata base, TableMetadata metadata) { + String newMetadataLocation = writeNewMetadata(metadata, currentVersion() + 1); + try { + Map<String, String> table = getTable(); + + if (!table.isEmpty()) { + validateMetadataLocation(table, base); + String oldMetadataLocation = base.metadataFileLocation(); + // Start atomic update + LOG.debug("Committing existing table: {}", tableName()); + updateTable(newMetadataLocation, oldMetadataLocation); + } else { + // table not exists create it + LOG.debug("Committing new table: {}", tableName()); + createTable(newMetadataLocation); + } + + } catch (SQLIntegrityConstraintViolationException e) { + throw new AlreadyExistsException(e, "Table already exists, maybe another process created it"); + } catch (SQLTimeoutException e) { + throw new UncheckedSQLException(e, "Database Connection timeout"); + } catch (SQLTransientConnectionException | SQLNonTransientConnectionException e) { + throw new UncheckedSQLException(e, "Database Connection failed"); + } catch (DataTruncation e) { + throw new UncheckedSQLException(e, "Database data truncation error"); + } catch (SQLWarning e) { + throw new UncheckedSQLException(e, "Database warning"); + } catch (SQLException e) { + throw new UncheckedSQLException(e, "Failed to connect to database"); + } catch (InterruptedException e) { + Thread.currentThread().interrupt(); + throw new UncheckedInterruptedException(e, "Interrupted during commit"); + } + } + + private void updateTable(String newMetadataLocation, String oldMetadataLocation) + throws SQLException, InterruptedException { + int updatedRecords = connections.run(conn -> { + try (PreparedStatement sql = conn.prepareStatement(JdbcUtil.DO_COMMIT_SQL)) { + // UPDATE + sql.setString(1, newMetadataLocation); + sql.setString(2, oldMetadataLocation); + // WHERE + sql.setString(3, catalogName); + sql.setString(4, JdbcUtil.namespaceToString(tableIdentifier.namespace())); + sql.setString(5, tableIdentifier.name()); + sql.setString(6, oldMetadataLocation); + return sql.executeUpdate(); + } + }); + + if (updatedRecords == 1) { + LOG.debug("Successfully committed to existing table: {}", tableIdentifier); + } else { + throw new CommitFailedException("Failed to update the table %s from catalog %s " + + "Maybe another process changed it", tableIdentifier, catalogName); + } + + } + + private void createTable(String newMetadataLocation) throws SQLException, InterruptedException { + int insertRecord = connections.run(conn -> { + try (PreparedStatement sql = conn.prepareStatement(JdbcUtil.DO_COMMIT_CREATE_TABLE_SQL)) { + sql.setString(1, catalogName); + sql.setString(2, JdbcUtil.namespaceToString(tableIdentifier.namespace())); + sql.setString(3, tableIdentifier.name()); + sql.setString(4, newMetadataLocation); + return sql.executeUpdate(); + } + }); + + if (insertRecord == 1) { + LOG.debug("Successfully committed to new table: {}", tableIdentifier); + } else { + throw new CommitFailedException("Failed to create table %s catalog %s", tableIdentifier, catalogName); + } + } + + private void validateMetadataLocation(Map<String, String> table, TableMetadata base) { + String catalogMetadataLocation = !table.isEmpty() ? table.get(JdbcUtil.METADATA_LOCATION) : null; + String baseMetadataLocation = base != null ? base.metadataFileLocation() : null; + + if (!Objects.equals(baseMetadataLocation, catalogMetadataLocation)) { + throw new CommitFailedException( + "Cannot commit %s because base metadata location '%s' is not same as the current Catalog location '%s'", Review comment: updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
