[GitHub] [iceberg] ayushchauhan0811 commented on pull request #2782: Support all operations in incremental scan

[GitBox]

ayushchauhan0811 commented on pull request #2782:
URL: https://github.com/apache/iceberg/pull/2782#issuecomment-877803297


   @RussellSpitzer As suspected, my changes are giving a temp view of the table 
from one snapshot id to another, which isn't the correct one in the case of 
compaction/merge jobs. 
   
   I think when we think of incremental scan b/w two snapshots, this is working 
fine - An incomplete view of the table. We can give users the option to 
configure which operations they want to include in the scan.
   
   <img width="937" alt="snapshot" 
src="https://user-images.githubusercontent.com/10010065/125197685-5bdd8b80-e27c-11eb-9329-aecfbb5997a6.png";>
   
   <img width="1259" alt="count" 
src="https://user-images.githubusercontent.com/10010065/125197682-584a0480-e27c-11eb-9af0-54736b56e0f4.png";>
   
   <img width="1440" alt="snapshot summary" 
src="https://user-images.githubusercontent.com/10010065/125197676-52542380-e27c-11eb-88b7-ccb68b1b48e3.png";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org