ayushchauhan0811 commented on pull request #2782:
URL: https://github.com/apache/iceberg/pull/2782#issuecomment-894633511


   @RussellSpitzer Need some help on how to change the test for delete files
   
   In the current test, we are listing the files b/w the snapshots. So for a 
snapshot range with delete operation, a file can be repeated as it will be 
provided by append operation as well as delete operation. You can refer this 
test case 
https://github.com/apache/iceberg/blob/master/core/src/test/java/org/apache/iceberg/TestIncrementalDataTableScan.java#L175
   
   After my change it will return the `D` file twice, so should I annotate 
delete files like this `-D`. I was trying a way to annotate but didn't find 
anything. So how should I proceed with this? 
   
   ```
   filesMatch(Lists.newArrayList("B", "C", "D", "D", "E", "I"), 
dataBetweenScan(1, 8));
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to