kbendick commented on a change in pull request #1421:
URL: https://github.com/apache/iceberg/pull/1421#discussion_r510415243
##########
File path:
spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReaderDeletes.java
##########
@@ -41,15 +42,32 @@
import org.apache.spark.sql.internal.SQLConf;
import org.junit.AfterClass;
import org.junit.BeforeClass;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
import static org.apache.hadoop.hive.conf.HiveConf.ConfVars.METASTOREURIS;
+@RunWith(Parameterized.class)
public abstract class TestSparkReaderDeletes extends DeleteReadTests {
private static TestHiveMetastore metastore = null;
protected static SparkSession spark = null;
protected static HiveCatalog catalog = null;
+ @Parameterized.Parameters(name = "Distributed Planning {0}")
+ public static Object[][] parameters() {
+ return new Object[][] {
+ new Object[] { false },
+ new Object[] { true },
+ };
+ }
Review comment:
Is there no way to collapse this into a single `Object[]`?
Nevermind. I recall this from some of the other spark tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
