kbendick commented on a change in pull request #1421:
URL: https://github.com/apache/iceberg/pull/1421#discussion_r510406876
##########
File path: api/src/main/java/org/apache/iceberg/DataFile.java
##########
@@ -80,7 +80,8 @@ static StructType getType(StructType partitionType) {
UPPER_BOUNDS,
KEY_METADATA,
SPLIT_OFFSETS,
- EQUALITY_IDS
+ EQUALITY_IDS,
+ ManifestFile.SPEC_ID.asOptional()
Review comment:
Should we document why this is optional @RussellSpitzer or do we prefer
to leave the code more pristine and maybe document elsewhere. Definitely
something I would imagine forgetting over time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
