RussellSpitzer commented on a change in pull request #2779:
URL: https://github.com/apache/iceberg/pull/2779#discussion_r671376896
##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java
##########
@@ -425,6 +455,21 @@ private static void
importUnpartitionedSparkTable(SparkSession spark, TableIdent
List<DataFile> files = TableMigrationUtil.listPartition(
partition, Util.uriToString(sourceTable.location()), format.get(),
spec, conf, metricsConfig, nameMapping);
+ if (checkDuplicateFiles) {
+ Dataset<Row> fileDs = spark.createDataset(
+ Lists.transform(files, f -> f.path().toString()),
Encoders.STRING())
+ .toDF("file_path");
+
+ Dataset<Row> existingFiles = loadMetadataTable(spark, targetTable,
MetadataTableType.ENTRIES);
+ Column joinCond =
existingFiles.col("data_file.file_path").equalTo(fileDs.col("file_path"));
+ Dataset<Row> duplicates = fileDs.join(existingFiles, joinCond);
+ List<String> duplicateList = Arrays.stream((Row[]) duplicates.head(10))
Review comment:
oh yeah .. :( the fix I think would be to select a column to prevent the
pruning issue ... which would be hacky. I guess we should really fix that
pruning issue :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
