RussellSpitzer commented on a change in pull request #2779:
URL: https://github.com/apache/iceberg/pull/2779#discussion_r674948179
##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java
##########
@@ -431,6 +462,18 @@ private static void
importUnpartitionedSparkTable(SparkSession spark, TableIdent
List<DataFile> files = TableMigrationUtil.listPartition(
partition, Util.uriToString(sourceTable.location()), format.get(),
spec, conf, metricsConfig, nameMapping);
+ if (checkDuplicateFiles) {
+ Dataset<Row> importedFiles = spark.createDataset(
+ Lists.transform(files, f -> f.path().toString()),
Encoders.STRING()).toDF("file_path");
Review comment:
I think this covers most cases, but probably will still have an issue
for the odd Authority issues. Like if I have the table where my metadata
entries have one authority or no authority, and my new files list doesn't. This
is probably still as close as we can get without actually resolving everything
I think ....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
