jackye1995 commented on a change in pull request #2841: URL: https://github.com/apache/iceberg/pull/2841#discussion_r672512582
########## File path: core/src/main/java/org/apache/iceberg/actions/RewriteDeleteStrategy.java ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.actions; + +import java.util.Map; +import org.apache.iceberg.DeleteFile; +import org.apache.iceberg.Table; + +public interface RewriteDeleteStrategy { + Review comment: I think we also need the methods similar to `RewriteStrategy` such as `name`, `validOptions` and `options` ########## File path: core/src/main/java/org/apache/iceberg/actions/RewriteDeleteStrategy.java ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.actions; + +import java.util.Map; +import org.apache.iceberg.DeleteFile; +import org.apache.iceberg.Table; + +public interface RewriteDeleteStrategy { + Review comment: I think we also need the methods similar to `RewriteStrategy` such as `name`, `validOptions` ########## File path: core/src/main/java/org/apache/iceberg/actions/RewriteDeleteStrategy.java ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.actions; + +import java.util.Map; +import org.apache.iceberg.DeleteFile; +import org.apache.iceberg.Table; + +public interface RewriteDeleteStrategy { + + /** + * Returns the table being modified by this rewrite strategy + */ + Table table(); + + /** + * Select the deletes to rewrite. + * + * @return iterable of original delete file to be replaced. + */ + Iterable<DeleteFile> selectDeletes(); Review comment: could you explain a bit about how these 2 interfaces will be used? For `RewriteStrategy` the method `Iterable<FileScanTask> selectFilesToRewrite(Iterable<FileScanTask> dataFiles)` was quite straightforward, but here the method has no arguments so I am not very sure how would it be used to actually select deletes. I think it goes to the fundamental question of what are some potential rewrite delete strategies? For rewrite data files we know there are well-known operations like bin-packing. For deletes, what are some strategies we plan to implement? ########## File path: core/src/main/java/org/apache/iceberg/actions/RewriteDeleteStrategy.java ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.actions; + +import java.util.Map; +import org.apache.iceberg.DeleteFile; +import org.apache.iceberg.Table; + +public interface RewriteDeleteStrategy { + Review comment: `name` is mostly used for logging purpose. I agree it is already in the class name, but for consistency with `RewriteStrategy` I think we can still have it here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
