chenjunjiedada commented on a change in pull request #2841: URL: https://github.com/apache/iceberg/pull/2841#discussion_r676788872
########## File path: core/src/main/java/org/apache/iceberg/actions/RewriteDeleteStrategy.java ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.actions; + +import java.util.Map; +import org.apache.iceberg.DeleteFile; +import org.apache.iceberg.Table; + +public interface RewriteDeleteStrategy { + + /** + * Returns the table being modified by this rewrite strategy + */ + Table table(); + + /** + * Select the deletes to rewrite. + * + * @return iterable of original delete file to be replaced. + */ + Iterable<DeleteFile> selectDeletes(); Review comment: I don't have a design doc right now, but most of the ideas come from discussions in https://github.com/apache/iceberg/pull/2216 and https://github.com/apache/iceberg/pull/2364. I'm working on rebasing #2216 to apply #2372 (API definition) and #2841 (delete row reader). That would be a full implementation and hopefully could give you the full picture of how these APIs are used. I will post in the following days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
