openinx commented on a change in pull request #2865:
URL: https://github.com/apache/iceberg/pull/2865#discussion_r676557241
##########
File path: core/src/main/java/org/apache/iceberg/BaseRewriteFiles.java
##########
@@ -63,15 +67,16 @@ private void verifyInputAndOutputFiles(Set<DataFile>
dataFilesToDelete, Set<Dele
}
@Override
- public RewriteFiles rewriteFiles(Set<DataFile> dataFilesToDelete,
Set<DeleteFile> deleteFilesToDelete,
+ public RewriteFiles rewriteFiles(Set<DataFile> dataFilesToReplace,
Set<DeleteFile> deleteFilesToReplace,
Set<DataFile> dataFilesToAdd,
Set<DeleteFile> deleteFilesToAdd) {
- verifyInputAndOutputFiles(dataFilesToDelete, deleteFilesToDelete,
dataFilesToAdd, deleteFilesToAdd);
+ verifyInputAndOutputFiles(dataFilesToReplace, deleteFilesToReplace,
dataFilesToAdd, deleteFilesToAdd);
Review comment:
As we've already changed the `dataFilesToDelete` and
`deleteFilesToDelete` to `dataFilesToReplace` & `deleteFilesToReplace`, then I
think we should also change the all the variables & arguments in
`verifyInputAndOutputFiles` for consistence ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
