rdblue commented on a change in pull request #2865:
URL: https://github.com/apache/iceberg/pull/2865#discussion_r676768147
##########
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##########
@@ -322,31 +365,25 @@ protected void validateDataFilesExist(TableMetadata base,
Long startingSnapshotI
if (matchingOperations.contains(currentSnapshot.operation())) {
newSnapshots.add(currentSnapshotId);
- for (ManifestFile manifest : currentSnapshot.dataManifests()) {
- if (manifest.snapshotId() == (long) currentSnapshotId) {
- manifests.add(manifest);
+ if (content == ManifestContent.DATA) {
+ for (ManifestFile manifest : currentSnapshot.dataManifests()) {
+ if (manifest.snapshotId() == (long) currentSnapshotId) {
Review comment:
No, there should never be a null snapshot ID returned from
`ManifestFile`. `null` was allowed because manifest lists were added later, but
manifest metadata is read any time a table is written so that the manifest data
is reliable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
